Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy links to clipboard #6088

Closed
mstv opened this issue Jan 10, 2019 · 5 comments
Closed

Copy links to clipboard #6088

mstv opened this issue Jan 10, 2019 · 5 comments

Comments

@mstv
Copy link
Member

mstv commented Jan 10, 2019

Feature description

Add a context menu item Copy link to the Commit Info which copies the link under the mouse to the Clipboard.

new

grafik

current

grafik

Environment

  • Git Extensions 3.01.00.0
  • Build f7e97be (Dirty)
  • Git 2.20.0.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.2117.0
  • DPI 96dpi (no scaling)
@gerhardol
Copy link
Member

OK for me, but Copy Commit Info should be on top

@mstv
Copy link
Member Author

mstv commented Jan 10, 2019

OK for me, but Copy Commit Info should be on top

I avoid right-clicking a link when I want to open the context menu. Then Copy commit info is on top because Copy link is invisible.
If I right-click a link, then I want to do something with the link and expect the regarding menu item(s) on top.
Note: I have added menu shortcuts. So one can right-click and hit C to copy the commit info regardless of the item's position and without moving the mouse to click the item.

grafik

How can one know whether the context menu was opened using the mouse or the keyboard (Shift+F10 or special key), especially in the event ContextMenuStrip.Opening?

Is there a benefit of having a dedicated issue for such a small feature, especially when it has already been implemented?

@gerhardol
Copy link
Member

If I right-click a link, then I want to do something with the link and expect the regarding menu item(s) on top.

OK

How can one know whether the context menu was opened using the mouse or the keyboard (Shift+F10 or special key), especially in the event ContextMenuStrip.Opening?

Do not know

Is there a benefit of having a dedicated issue for such a small feature, especially when it has already been implemented?

Is this related to submitting this issue first, then a PR?
If so, this controls how issues/PRs appear in the release notes.
It may also be good to separate the discussion on how to do with implementation details.
But @RussKie is not strict about it.
In this case it should have been OK with a PR directly.

@RussKie
Copy link
Member

RussKie commented Jan 11, 2019

It may also be good to separate the discussion on how to do with implementation details.
But @RussKie is not strict about it.

It is still good to have a discussion when fix isn't trivial 😏

Should we show only "Copy link (...)" menu when right clicking on a link?

@mstv
Copy link
Member Author

mstv commented Jan 12, 2019

Should we show only "Copy link (...)" menu when right clicking on a link?

Gerhard even wanted the Copy commit info before the Copy link initially.
I think having Copy link as the first item is the best compromise because then it doesn't matter where one right-clicks into the Commit Info and every available functionality is visible.

@RussKie RussKie added this to the 3.1.0 milestone Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants