Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect 'git clone' prefix and ignore #6260

Closed
thimmy687 opened this issue Feb 16, 2019 · 7 comments · Fixed by #9018 or #9266
Closed

Detect 'git clone' prefix and ignore #6260

thimmy687 opened this issue Feb 16, 2019 · 7 comments · Fixed by #9018 or #9266
Assignees
Labels
area: plugins :neckbeard: status: pull request only Requested changes won't be implemented by the Core team, community PRs are welcome 🤓 good first issue type: feature request

Comments

@thimmy687
Copy link
Contributor

thimmy687 commented Feb 16, 2019

Current behaviour

I copy a branch from gerrit code review server (git clone ssh://...), want to clone a new repo and got and error ( it tries to execute git clone git clone ... )

Expected behaviour

The prefix git clone is detected automatically and will be ignored

Steps to reproduce

Copy and paste a link from gerrit

Screenshots

Did this work in previous version of GitExtensions

Current (3.xx)

Environment

  • Git Extensions 3.1.0.5877
  • Build bb1687f
  • Git 2.19.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3416.0
  • DPI 96dpi (no scaling)

Diagnostics

@thimmy687 thimmy687 changed the title Detect 'git clone' prefix anderen ignore Detect 'git clone' prefix and ignore Feb 16, 2019
@gerhardol gerhardol added type: feature request :neckbeard: status: pull request only Requested changes won't be implemented by the Core team, community PRs are welcome 🤓 good first issue ❓ status: incorrectly filled template Issue template is incorrectly filled labels Feb 16, 2019
@gerhardol
Copy link
Member

I personally feal that a user should handle this, but if someone writes a PR I would not block it.

@vbjay
Copy link
Contributor

vbjay commented Feb 16, 2019

You should just include the URL.

@thimmy687
Copy link
Contributor Author

thimmy687 commented Feb 18, 2019

example string:

git clone ssh://username@gerrit-server:/PROJECT

@vbjay
Copy link
Contributor

vbjay commented Feb 18, 2019

Only include ssh://...

@thimmy687
Copy link
Contributor Author

Maybe it is possible to extend this to also detect the clone with hook from gerrit

Example:

"Clone with commit-msg hook": "git clone http://gerrithost:8080/${project} \u0026\u0026 scp -p -P 29418 jdoe@gerrithost:hooks/commit-msg ${project}/.git/hooks/"

@RussKie RussKie added area: plugins and removed ❓ status: incorrectly filled template Issue template is incorrectly filled labels Jun 13, 2019
@nyankoframe
Copy link
Contributor

I'd be interested to work on this issue if it's not already assigned. I believe the fix should be as straightforward as detecting that git clone is in the URL and removing it.

@gerhardol
Copy link
Member

I'd be interested to work on this issue if it's not already assigned. I believe the fix should be as straightforward as detecting that git clone is in the URL and removing it.

The base use case was just detecting git clone prefix if the following seem to be an url.

@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Mar 20, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Apr 24, 2021
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Apr 26, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Jun 5, 2021
@ghost ghost added 🚧 status: in progress Issues which have associated PRs and removed 🚧 status: in progress Issues which have associated PRs labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: plugins :neckbeard: status: pull request only Requested changes won't be implemented by the Core team, community PRs are welcome 🤓 good first issue type: feature request
Projects
None yet
5 participants