Vertical ruler position not correctly read from settings

[crypto-rsa]

Current behaviour

When opening a new diff window (like a file history), the vertical ruler position is not updated according to the settings - it has the default value.

Expected behaviour

The ruler should have correct position right from the start.

Steps to reproduce

1. Set a non-default value for the vertical ruler position (in Settings - Detailed - Diff Viewer).
2. Open the history of any file.
3. The ruler is at the default position.

The ruler only moves to the correct position after clicking the Settings icon in the diff view and clicking OK in the settings window (no editing needed), which suggests the settings are not loaded correctly the first time the window opens.

Did this work in previous version of GitExtensions

Did not check.

Environment

• Git Extensions 3.1.0
• Build 7a5680d
• Git 2.21.0.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3260.0
• DPI 96dpi (no scaling)

[RussKie]

Please test #6392 and confirm the fix

[thimmy687]

Hi the same issue is in the commit window

my setting is on 120 but on opening the commit window the line is displayed at the default position.

If I open and close the settings without changing something the line moves to the correct position.

before:

and after:

Here is the version info:

• Git Extensions 3.0.2.5232
• Build 23b6f51
• Git 2.20.0.windows.1
• Microsoft Windows NT 10.0.16299.0
• .NET Framework 4.7.3394.0
• DPI 96dpi (no scaling)

[RussKie]

@thimmy687 please try the 3.1-RC1 and see if it was fixed

[thimmy687]

I will check this, thx

[thimmy687]

Hi it's working well now :)

but it leads me to another issue 😅 which I will report separatly