Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Dialog: New submodule without text if unstaged #6559

Closed
mstv opened this issue May 14, 2019 · 4 comments · Fixed by #6627
Closed

Commit Dialog: New submodule without text if unstaged #6559

mstv opened this issue May 14, 2019 · 4 comments · Fixed by #6627
Labels
type: bug 🐛
Milestone
3.1.1

Comments

@mstv
Copy link
Member

mstv commented May 14, 2019

Current behaviour

Only a new file icon + without the folder name of a new submodule can be seen in the list of unstaged files.

Expected behaviour

Text displayed as in the list of staged files.

Steps to reproduce

  • add a new submodule
  • unstage the changes in the Commit dialog

Screenshots

grafik

Did this work in previous version of GitExtensions

I don't know.

Environment

  • Git Extensions 3.1.0
  • Build 678b69e
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.3324.0
  • DPI 96dpi (no scaling)
@RussKie RussKie added type: bug 🐛 🤓 good first issue up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels May 14, 2019
@RussKie
Copy link
Member

RussKie commented May 14, 2019

This is pretty bad...
We need to get it fixed for 3.1.1

@RussKie RussKie added this to the 3.1.1 milestone May 14, 2019
@mstv mstv removed their assignment May 14, 2019
@mstv
Copy link
Member Author

mstv commented May 14, 2019

My main PC with the dev env died yesterday. It will take some time to get a replacement and to install it.

@RussKie
Copy link
Member

RussKie commented May 16, 2019

Ouch! Hope you get it up and running without major headaches.
Chocolatey is quote good in streamlining the software install 😉

@RussKie
Copy link
Member

RussKie commented May 21, 2019

@mstv do you want this fix to be in 3.1.1?

This was referenced May 21, 2019
Merged
Merged
@RussKie RussKie removed 🤓 good first issue ❕ priority: high up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

Do not split paths at trailing slash of submodules mstv/gitextensions
2 participants
@RussKie @mstv