[NBug] Illegal characters in path.

[cfamax]

Current behaviour

When clicking on 'Clone repository..' in the Start menu or on the splash page, an error occurs.

Expected behaviour

The normal popup to clone a repository is displayed.

After a couple minutes I realized I could X out the NBug error dialog, but this is a poor user experience. A more helpful dialog would be better.

Steps to reproduce

I found that the issue appears to be that in my clipboard there was text with return carriages in it, among other text - the functionality could use some pre-validation before attempting to load the contents of the clipboard.

The following was the latest entry on my clipboard:

git checkout   release/3.0.0.2
git checkout   release/3.0.0.3
git checkout   release/3.0.1
git checkout   release/3.1.0
git checkout   release/3.1.1-NOMERGE
git checkout   release/3.2.0

Error Details

System.ArgumentException: Illegal characters in path.
   at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional)
   at System.IO.Path.Combine(String path1, String path2)
   at GitUI.CommandsDialogs.FormClone.ToTextUpdate(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnTextChanged(EventArgs e)
   at System.Windows.Forms.Control.set_Text(String value)
   at System.Windows.Forms.TextBoxBase.set_Text(String value)
   at System.Windows.Forms.TextBox.set_Text(String value)
   at GitUI.CommandsDialogs.FormClone.FromTextUpdate(Object sender, EventArgs e)
   at GitUI.CommandsDialogs.FormClone.OnRuntimeLoad(EventArgs e)
   at GitUI.GitExtensionsForm.OnLoad(EventArgs e)
   at System.Windows.Forms.Form.OnCreateControl()
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl()
   at System.Windows.Forms.Control.WmShowWindow(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Form.WmShowWindow(Message& m)
   at ResourceManager.GitExtensionsFormBase.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Additional information

Environment

• Git Extensions 3.3.1.7897
• Build 5a97671
• Git 2.25.0.windows.1
• Microsoft Windows NT 10.0.18363.0
• .NET Framework 4.8.4180.0
• DPI 96dpi (no scaling)

[archivarius-bot]

Thank you for the bug report 👍

Sadly, it appears some important information is still missing, which you may have overlooked while submitting the bug.
Without this information we may not be able to assist you in resolving the issue.

Please review your submission, fill the missing information in and post a new comment to ping us back to re-open the issue.
Thanks again

[duplicates-detector-bot]

Potential duplicates:

• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 
• 

[cfamax]

This appears related to #7528, although in this case I hadn't even seen the popup yet so it wasn't clear that the text validation was throwing the error.

[gerhardol]

Duplicate of #7528

A check added in master #7633 (so popup instead)
Please try 3.4 RC