Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difftool does not work with staged renamed file in FormCommit dialog #8600

Closed
hieuxlu opened this issue Nov 7, 2020 · 1 comment · Fixed by #8601
Closed

Difftool does not work with staged renamed file in FormCommit dialog #8600

hieuxlu opened this issue Nov 7, 2020 · 1 comment · Fixed by #8601

Comments

@hieuxlu
Copy link
Contributor

hieuxlu commented Nov 7, 2020

Current behaviour

  • When launching a difftool for a renamed file, the remote file (which is renamed locally) does not appear in any difftool (tried with Kdiff3, BC, VSCode)

Expected behaviour

  • Difftool for renamed file should work like normal files, where a temporary remote file should exist.

Steps to reproduce

  1. Rename a file
  2. Stage all
  3. Select the renamed file in commit window and press F3 (to launch external difftool)

Screenshots

Did this work in previous version of GitExtensions

  • I think it should. I have never experienced this problem, and I've used Git Extensions for 5 years (thank you very much guys)
  • It works in RevisionDiffControl

Environment

  • Git Extensions 3.4.3.9999
  • Build d4b0f48
  • Git 2.28.0.windows.1
  • Microsoft Windows NT 10.0.17763.0
  • .NET Framework 4.8.4250.0
  • DPI 144dpi (150% scaling)

Diagnostics

@hieuxlu
Copy link
Contributor Author

hieuxlu commented Nov 7, 2020

I can start working on this issue.

@hieuxlu hieuxlu changed the title Difftool does not work with renamed file Difftool does not work with staged renamed file in FormCommit dialog Nov 7, 2020
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Nov 7, 2020
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant