Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash pop is not refreshing the window #9121

Closed
pedrolamas opened this issue Apr 26, 2021 · 2 comments · Fixed by #9145
Closed

Stash pop is not refreshing the window #9121

pedrolamas opened this issue Apr 26, 2021 · 2 comments · Fixed by #9145

Comments

@pedrolamas
Copy link
Contributor

Current behaviour

The window is not being refresh after a stash pop operation and so still shows the previous stashed code, even when it is not there anymore.

Expected behaviour

The window should be refreshed after a stash pop operation

Steps to reproduce

  1. Stash some code
  2. Observe that the window shows the stashed code with the other commits
  3. Do a stash pop directly via menu option on toolbar
  4. Observe commits in window

Screenshots

Did this work in previous version of GitExtensions

Yes, this was working fine just on previous stable version to current 3.5.0.11713

Environment

  • Git Extensions 3.5.0.11713
  • Build 0a5ef9c (Dirty)
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19043.0
  • .NET Framework 4.8.4341.0
  • DPI 192dpi (200% scaling)

Diagnostics

@gerhardol
Copy link
Member

gerhardol commented Apr 26, 2021

Do you mean the revision graph?

If so, that was introduced with 7cba8ce 4b3609f

@mstv
Copy link
Member

mstv commented Apr 26, 2021

The graph is not refreshed after Stash pop. So the popped stash is still displayed until refresh.

How is it related to RunBash, @gerhardol? Did you mean a different commit?


After continuing some of the rebase operations using the top banner buttons, the whole graph disappears sometimes. (I don't have a clear repro yet.)
There were changes to these banners. Perhaps a refresh got lost there.

@gerhardol gerhardol added this to the 3.5.1 milestone May 2, 2021
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label May 3, 2021
@ghost ghost closed this as completed in #9145 May 7, 2021
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label May 7, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants