Number of changed files disappears

[mstv]

Environment

• Git Extensions 33.33.33
• Build c3b0d64
• Git 2.35.2.windows.1
• Microsoft Windows NT 10.0.19044.0
• .NET 6.0.3
• DPI 96dpi (no scaling)

Issue description

The Number of changed files disappears from the Commit button and from the Artificial Commits occasionally (too often).
The state overlay of the taskbar icon is affected, too.

Basically, the Commit button and the Artificial Commits should not be undecorated while the status is updated or is invalidated because a modal dialog is active.
Currently, it looks like there are no changes - very misleading.

Steps to reproduce

If I knew

Did this work in previous version of GitExtensions?

yes

Diagnostics

No response

[gerhardol]

This was changed partly by your comments as the old value was misleading.
The commit button is grey in this situation. Some similar marker would be nice for artificial commits too. Question mark?

[mstv]

This was changed partly by your comments as the old value was misleading. The commit button is grey in this situation.

This is true only if GE is minimized or if a modal dialog is active.
But if the main issue strikes, there is nothing: no taskbar icon overlay, green Commit button.

Some similar marker would be nice for artificial commits too. Question mark?

Yes, please. That's what I had in mind.

[gerhardol]

This was changed partly by your comments as the old value was misleading. The commit button is grey in this situation.

This is true only if GE is minimized or if a modal dialog is active. But if the main issue strikes, there is nothing: no taskbar icon overlay, green Commit button.

Not sure what this is, will take a look.

Some similar marker would be nice for artificial commits too. Question mark?

Yes, please. That's what I had in mind.

It is easier to explain when there are no changes, so "blank" if modal or no information yet.

or "pen" and a zero

[mstv]

I have found how to reproduce this or a related issue.
If git processes are terminated on cancellation request, the status of the artificial commits is not updated.
The issue occurs with 3cd35a3 in combination with 903f924 on top of #9958:

This proves that Application.DoEvents() must not be called (in RefreshRevisions, #9906 (comment) 👍).

Though despite of this, the application behavior must not change if git processes are terminated on cancellation.
I suspect that the change-count update cancels things too early. If we let git run to the end, the result is displayed although the update was cancelled.