Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect results with --exclude-tags-regex #725

Open
christopher-dG opened this issue May 19, 2019 · 0 comments
Open

Incorrect results with --exclude-tags-regex #725

christopher-dG opened this issue May 19, 2019 · 0 comments

Comments

@christopher-dG
Copy link

As a workaround for #724, I hacked a regex for --exclude-tags-regex to accept any string except my specific tag: ^(?!v0\.6\.0$). This works in that the only section generated is for tag v0.6.0, but the "Merged pull requests" sections contains far more PRs than were actually merged in that time frame (30/33 total PRs are displayed, the correct number is 9).

Tested with this command:

# Gives correct results, but contains sections for all tags
github_changelog_generator -t <token> -u invenia -p PkgTemplates.jl

# Gives incorrect results for v0.6.0 section (the only section)
github_changelog_generator -t <token> -u invenia -p PkgTemplates.jl --exclude-tags-regex '^(?!v0\.6\.0$)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant