Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable actions in mirror creation dialog #72

Open
ajhenry opened this issue Apr 4, 2024 · 3 comments
Open

Add option to disable actions in mirror creation dialog #72

ajhenry opened this issue Apr 4, 2024 · 3 comments
Assignees

Comments

@ajhenry
Copy link
Contributor

ajhenry commented Apr 4, 2024

As discussed in #71 it makes sense to create a mirror with actions disabled (this will come with its own caveats but we can cross that bridge when we get there 🌉)

This will be an option that will be off be default in the creation dialog

Let’s also add an env variable that can force this option to be always on, always off, or toggle-able

@ahpook
Copy link
Contributor

ahpook commented Apr 4, 2024

I feel like there will almost certainly be additional settings that people would want. Not sure if this is feasible, but rather than hardcode just actions on/off, could there be a config stanza of settings names -> values that would be enforced on new repo creation? like this one would be

settings:
  actions:
    permissions: 
      enabled: false

... which would map to the repos/actions/permissions API path.

@ajhenry
Copy link
Contributor Author

ajhenry commented Apr 4, 2024

That’s a good point, I was thinking about how we could setup a “default” set of permissions on a mirror. Having a config file wouldn’t be hard to implement on self-deployments. I’ll do some more investigating

@ahpook
Copy link
Contributor

ahpook commented Apr 4, 2024

I know lots of folks use github/safe-settings for general-purpose repo creation policy - maybe there's some prior art there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants