Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quote character problematic in CoffeeScript #2529

Closed
mdouglasbrett opened this issue Jul 31, 2015 · 2 comments
Closed

Single quote character problematic in CoffeeScript #2529

mdouglasbrett opened this issue Jul 31, 2015 · 2 comments

Comments

@mdouglasbrett
Copy link

Hi guys,

Hope you're ok, I came across this when I was looking through a README (https://github.com/zooniverse/Panoptes-Front-End):

<ChangeListener target={auth}>{=>
  <PromiseRenderer promise={auth.checkCurrent()}>{(user) =>
    if user?
      <p>User is {user.display_name}</p>
    else
      <p>Nobody's signed in.</p>
  }</PromiseRenderer>
}</ChangeListener>

The single quote starts a string that doesn't end. I had a go at escaping it and I'm not sure that you can:

<ChangeListener target={auth}>{=>
  <PromiseRenderer promise={auth.checkCurrent()}>{(user) =>
    if user?
      <p>User is {user.display_name}</p>
    else
      <p>Nobody\'s signed in.</p>
  }</PromiseRenderer>
}</ChangeListener>

Is this a bug, or am I missing something incredibly obvious?

All the best,

Mike

@pchaigno
Copy link
Contributor

pchaigno commented Aug 1, 2015

@mdouglasbrett Linguist only selects the appropriate grammar for highlighting. In the case of CoffeeScript, it uses this Atom grammar. You should open an issue there.

@mdouglasbrett
Copy link
Author

Cool. Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants