Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile syntax highlighting bug #2710

Closed
philtay opened this issue Nov 1, 2015 · 3 comments
Closed

Makefile syntax highlighting bug #2710

philtay opened this issue Nov 1, 2015 · 3 comments

Comments

@philtay
Copy link

philtay commented Nov 1, 2015

Have a look at this gist:

https://gist.github.com/philtay/5a647f5a573d1052e7f7

Repro:

define foobar
$(and $(filter-out undefined,$(origin 1)),$(1))
endef

define test
command
endef
@pchaigno
Copy link
Contributor

pchaigno commented Nov 1, 2015

Linguist only selects the grammar to use for highlighting. In the case of Makefile, GitHub uses textmate/make.tmbundle. You should open an issue there.

@keplersj
Copy link
Contributor

keplersj commented Nov 4, 2015

@philtay You may also try filing an issue on the Atom version, the tmbundle Linguist is using seems a little abandoned.

I just checked and this issue still exists with the Atom version: Lightroom sample

@arfon
Copy link
Contributor

arfon commented Dec 3, 2015

As this looks to now be fixed in the upstream grammar this will be fixed in the next release of Linguist.

@arfon arfon closed this as completed Dec 3, 2015
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants