Incorrect highlighting with C/C++ when macro call does not end in semicolon

[tristan957]

Not much else to say. Any extra information can be found at jeff-hykin/better-cpp-syntax#311 because this is basically a duplicate. Please take a look at the line I specifically called out with an all-caps comment.

Preliminary Steps

Please confirm you have...

• reviewed How Linguist Works,
• reviewed the Troubleshooting docs,
• considered implementing an override,
• verified an issue has not already been logged for your issue (linguist issues).

Problem Description

When a macro invocation does not end in a semicolon, the following syntax is incorrectly colored.

URL of the affected repository:

jeff-hykin/better-cpp-syntax#311

Last modified on:

2019-07-15

Expected language:

C/C++

Detected language:

C/C++

[lildude]

As you've already identified, this is a problem with the grammar and not Linguist. As per the README at https://github.com/github/linguist#theres-a-problem-with-the-syntax-highlighting-of-a-file

If you experience an issue with the syntax-highlighting on GitHub, please report the issue to the upstream grammar repository, not here. Grammars are updated every time we build the Linguist gem so upstream bug fixes are automatically incorporated as they are fixed.

As you have already done this, I'm closing this issue. Any grammar updates will automatically be pulled in as and when releases are made.

[tristan957]

Well the upstream I reported the issue to isn't even the upstream you guys use for your grammar.

[tristan957]

Has been rectified textmate/c.tmbundle#67

[lildude]

Well the upstream I reported the issue to isn't even the upstream you guys use for your grammar.

Whoops missed that as I wasn't expecting you to reference a completely different grammar 😊.

Has been rectified textmate/c.tmbundle#67

🙇