Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsh files have GLSL as associated language #5039

Open
serkonda7 opened this issue Oct 3, 2020 · 1 comment
Open

vsh files have GLSL as associated language #5039

serkonda7 opened this issue Oct 3, 2020 · 1 comment
Labels
Good First Issue This is a great opportunity to start contributing to Linguist Misidentified Language

Comments

@serkonda7
Copy link
Contributor

Preliminary Steps

Please confirm you have...

Problem Description

URL of the affected repository:

https://github.com/serkonda7/v-sololearn-coding-challenges

Expected language:

The language should be V.

Detected language:

GLSL

@lildude
Copy link
Member

lildude commented Oct 5, 2020

Looks like we have two possible solutions to this:

  1. Add the .vsh to the V language entry and add a heuristic to differentiate it from GLSL (the only language .vsh is currently associated with)
  2. Add v as an interpreter for V as that's how the .vsh script seems to be using it.

We'd certainly welcome a PR to do one or both of these.

@lildude lildude added Good First Issue This is a great opportunity to start contributing to Linguist Misidentified Language labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a great opportunity to start contributing to Linguist Misidentified Language
Projects
None yet
Development

No branches or pull requests

2 participants