Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gren release and changelog lag one tag behind #181

Closed
martingerdin opened this issue Aug 22, 2018 · 10 comments
Closed

Gren release and changelog lag one tag behind #181

martingerdin opened this issue Aug 22, 2018 · 10 comments

Comments

@martingerdin
Copy link

martingerdin commented Aug 22, 2018

Thank you for gren!

Now, if I do:

echo "This is a test" >> README.md
git add README.md
git commit -m "Add README"
git push
git tag v1
git push --tags
hub issue create -m "Update README"
echo "Update" >> README.md
git add README.md
git commit -m "Fix #1"
git push
git tag v2
git push --tags
gren release # I expect to see "Update README" in these release notes
echo "Update again" >> README.md
git add README.md
git commit -m "Update again"
git push
git tag v3
git push --tags
gren release # But instead I see "Update README" here

Then I would expect to see "Update README" in the release notes for v2, because "#1" was closed before the commit was tagged v2. It doesn't, however, instead it shows up in the v3 release.

Is this the expected behavior, and am I misunderstanding something? If so, what can I do to have "Update README" show up in the v2 release notes?

@rchabin
Copy link

rchabin commented Aug 24, 2018

Same issue for me 👍

@erickertz
Copy link

Thanks for Gren! Also experiencing this issue.

@alexcanessa
Copy link
Member

alexcanessa commented Oct 17, 2018

What version of gren are you using? Try the new version and see if still an issue please 🙏

@erickertz
Copy link

version 0.17.0. this is the first time I've used gren. It always seems to skip the first commit in a release in the notes for some reason, which I think is what the OP is also saying. For instance:

  1. Create notes for 1.0.0:
    gren release --override --data-source=commits --tags 1.0.0

  2. Create notes for 1.0.1:
    gren release --override --data-source=commits --tags 1.0.1

OUTCOME: 1.0.1 will be missing the notes from the first commit.

Also, doing:
gren release --override --data-source=commits --tags 1.0.1..1.0.0

OUTCOME: 1.0.1 will be missing the notes from the first commit.

@alexcanessa
Copy link
Member

Ok I'll have a look, ta

@idlem1nd
Copy link

idlem1nd commented Mar 1, 2019

Also seeing this in version 0.17.0.

@Tybot204
Copy link
Contributor

Tybot204 commented Apr 22, 2019

Also seeing this issue, but with prs given as the data source. If a merged PR commit is tagged, it will be missing from that tag's release notes.

Seems related to #128?

@mlrv
Copy link

mlrv commented Sep 23, 2019

Any update on this?

@JuergenSimon
Copy link

Actually it's a little worse than simply lagging for me. The commits that coincide with the tag simply do not enter the changelog.

@alexcanessa
Copy link
Member

alexcanessa commented Dec 12, 2019

This should be closed by #220

And duplicate of #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants