Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gren takes all PRs, not only the one between tags #305

Closed
antoinewg opened this issue Oct 22, 2021 · 1 comment
Closed

Gren takes all PRs, not only the one between tags #305

antoinewg opened this issue Oct 22, 2021 · 1 comment

Comments

@antoinewg
Copy link

Hello,
First thanks a lot for the tool, it's amazing.
However I have a slight issue with it:

Here's my gren config file:

{
  "dataSource": "prs",
  "prefix": "",
  "onlyMilestones": false,
  "ignoreTagsWith": ["test", "hotfix", "deploy"],
  "groupBy": {
    "🔥 Enhancements:": ["enhancement", "feature"],
    "🐛 Bug Fixes:": ["bug"],
    "⚙️ Tech:": ["tech"],
    "📜 Documentation:": ["documentation"]
  },
  "changelogFilename": "CHANGELOG.md",
  "template": {
    "issue": "- {{name}} [{{text}}]({{url}})"
  }
}

So basically I want to group the PRs between two tags for each release. The problem is that for each release it takes the information from all the PRs, and filter the one between the previous tag and the tag to release.

Let me explain with an example taken from this repo: https://github.com/antoinewg/smartlists.

From the commit log, we can see the commits:

  • v1.0.3
  • PR 7
  • v1.0.2
  • PR 6, 5, 4, 3
  • v1.0.1
  • PR 2
  • v1.0.0
  • PR 1

However, when I launch gren release --tags=all --override, all releases (v1.0.1, v1.0.2, v1.0.3) have every PRs inside, and the first one v1.0.0 doesn't have any changelog.

Could you explain what I'm doing wrong ? Or how to "attach" a PR to a particular tag.

For more details, here's the repo on which I've tested it: https://github.com/antoinewg/smartlists/releases

Best regards,
Antoine

@antoinewg
Copy link
Author

Closing because when re-running the same command it works. It seems that it needs the releases to exists before being able to assigne a PR to a tag/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant