Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e154/smart-home: endpoint/flow.go; 25 LoC #36

Open
githubvet opened this issue Jan 9, 2021 · 0 comments
Open

e154/smart-home: endpoint/flow.go; 25 LoC #36

githubvet opened this issue Jan 9, 2021 · 0 comments

Comments

@githubvet
Copy link

Found a possible issue in e154/smart-home at endpoint/flow.go

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

Click here to see the code in its original context.

Click here to show the 25 line(s) of Go which triggered the analyzer.
for _, w := range params.Workers {
	worker := &m.Worker{}
	common.Copy(&worker, &w)
	worker.WorkflowId = newFlow.Workflow.Id
	worker.FlowId = newFlow.Id
	worker.DeviceActionId = w.DeviceAction.Id

	_, errs = worker.Valid()
	if len(errs) > 0 {
		for _, err := range errs {
			log.Errorf("%s %s", err.Key, err.Message)
		}
		return
	}

	if worker.Id == 0 {
		if _, err = tx.Worker.Add(worker); err != nil {
			return
		}
	} else {
		if err = tx.Worker.Update(worker); err != nil {
			return
		}
	}
}
Click here to show extra information the analyzer produced.
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Copy 2} was not found in the callgraph; reference was passed directly to third-party code

Leave a reaction on this issue to contribute to the project by classifying this instance as a Bug 👎, Mitigated 👍, or Desirable Behavior 🚀
See the descriptions of the classifications here for more information.

commit ID: 08bfcca81c321b893cad87842a4ea40713f62e09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant