RBLViewController #46
Conversation
…nt custom_viewWillMoveToSuperView
…ass involving layout
ghost
assigned 
|
Hi Colin! Sorry it's taken so long on this—I hope to give it a good review in the next day or two. Because oldjoshcodelolz. |
|
Ah in the meantime, it looks like this doesn't merge cleanly as-is. Could you merge in upstream? |
|
Okay i'll merge in upstream as soon as I can. Im not on the best network for that at the moment, so I'll wait just a little bit till later this afternoon. |
|
Alright so a couple broad comments first.
I'm inclined to think that the circumstances in which appearance methods should be called be left entirely to the user. In OS X land it seems waaaaaay too hard to know exactly what "appear" means universally. |
| dispatch_once(&onceToken, ^{ | ||
| //swizzle swizzle... | ||
| [self rbl_swapMethod:@selector(viewWillMoveToSuperview:) with:@selector(custom_viewWillMoveToSuperview:)]; | ||
| [self rbl_swapMethod:@selector(viewDidMoveToSuperview) with:@selector(custom_viewDidMoveToSuperview)]; |
There was a problem hiding this comment.
Sorry I don't mean to jump on @joshaber's territory here, but the indentation here looks like it's spaces and not tabs.
There was a problem hiding this comment.
Yikes, there was a couple lines that had spaces instead of tabs. I don't know how I missed this. I'll fix it quickly. Looks like 4-6 lines that had spaces instead of tabs.
|
Oh man I'm really sorry Colin. This totally dropped off my radar. Next time give me a swift kick. Could you merge master in so this merges cleanly? Then we should be ✨ |
|
💥 @Machx Helping Josh out here a bit, looks like you need to update the submodules as well as they seem to be pointing toward old commits. |
|
there we go I think I got it all sorted out. let me know if there is anything else I need to do. Thanks! |
|
💥 👶 |
|
👏 |
|
One might say this pull is "sizzling" |
This is a pull request for RBLViewController as discussed in Issue #33 to get feedback before merging in. I started here with simply getting much of what Josh did in JAViewController working on Rebel.
I should also note that I had to add a NSObject swizzling methods category that seems like it really belongs somewhere else in foundation level code.
I am open to any changes that should be made or feature additions. I am already starting to use this class in my new project I am working on so I should get more ideas of things to add as time progresses. Thanks