New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GitHub pane dispose of its view models #1360

Closed
jcansdale opened this Issue Dec 1, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jcansdale
Contributor

jcansdale commented Dec 1, 2017

At the moment it isn't obvious how to make view models dispose of their resources.

In PR #1359 I've used a workaround that assumes that only one instance of PullRequestDetailViewModel will exist at a time:
6c4ff1b#diff-347b0f42676901bf61fcbabb3c74ec3eR88

If the the GitHub pane starts disposing of its view models, this can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment