Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Make GitHub pane dispose of its view models #1360

Closed
jcansdale opened this issue Dec 1, 2017 · 0 comments
Closed

Make GitHub pane dispose of its view models #1360

jcansdale opened this issue Dec 1, 2017 · 0 comments

Comments

@jcansdale
Copy link
Collaborator

At the moment it isn't obvious how to make view models dispose of their resources.

In PR #1359 I've used a workaround that assumes that only one instance of PullRequestDetailViewModel will exist at a time:
6c4ff1b#diff-347b0f42676901bf61fcbabb3c74ec3eR88

If the the GitHub pane starts disposing of its view models, this can be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant