Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHSA-gwjw-ph82-w683 - Malware in duo_web_sdk #2701

Closed
pidydx opened this issue Sep 2, 2023 · 5 comments
Closed

GHSA-gwjw-ph82-w683 - Malware in duo_web_sdk #2701

pidydx opened this issue Sep 2, 2023 · 5 comments

Comments

@pidydx
Copy link

pidydx commented Sep 2, 2023

As far as I can tell duo_web_sdk is deprecated, but it is Duo's code and not malware. https://github.com/duosecurity/duo_web_sdk

Can anyone explain why this advisory exists because the advisory itself has no references and simply claims it is all malware and I can't find any reference anywhere else suggesting that this package has ever been compromised or hijacked.

@darakian
Copy link
Contributor

The advisory refers to the npm package here
https://www.npmjs.com/package/duo_web_sdk
Which indeed has been pulled down.

@KateCatlin
Copy link
Collaborator

@pidydx any further questions here or shall we close this issue down?

@pidydx
Copy link
Author

pidydx commented Oct 20, 2023

@darakian Thanks for the explanation!

@KateCatlin I ran into this problem because npm audit fix blew up on this warning

duo_web_sdk  *
Severity: critical
Malware in duo_web_sdk - https://github.com/advisories/GHSA-gwjw-ph82-w683
No fix available
node_modules/duo_web_sdk

But the package.json involved isn't pointing at that package. https://github.com/bitwarden/clients/blob/e9f0c07b02c539a365bb68c678c31f1ba4e04dd8/package.json#L173C53-L173C53

I'm not super familiar with the npm ecosystem, but it sounds like it might be a bug elsewhere so this is probably fine to close. It might be worth it to add that package link to the advisory to make it clear what the advisory is referring to since duo publishes their own duo_web_sdk. Thanks!

@darakian
Copy link
Contributor

@pidydx Ah, interesting. I think you've stumbled on a bug in npm doing package resolution where it thinks the package is coming from npmjs.com and hence delivers the advisory. I'll forward this along to get it in front of a team that can look into a fix for it 👍

@pidydx
Copy link
Author

pidydx commented Nov 19, 2023

@KateCatlin should be good, I will close.

@darakian They way I stumble onto bugs this would not surprise me.

Thanks all!

@pidydx pidydx closed this as completed Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants