Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Google's Navigation Drawer #368

Closed
pietrorampini opened this issue May 25, 2013 · 10 comments
Closed

Integrate with Google's Navigation Drawer #368

pietrorampini opened this issue May 25, 2013 · 10 comments

Comments

@pietrorampini
Copy link

http://developer.android.com/training/implementing-navigation/nav-drawer.html

@BudgieInWA
Copy link

Something like this?
Drawer Mockup

Unfortunately, I am not familiar enough with the Android APIs to take on something like this.

@atermenji
Copy link
Contributor

looks nice. Items from ActionBar spinner are the best candidates for Navigation Drawer panel

@BudgieInWA
Copy link

Yep. The notification item would link to #327. "People" would link to a view displaying a list of followers and followed people.

@atermenji
Copy link
Contributor

I guess there is no need to remove tabs and swyping, so that followers/following/repos screens could left as they are

@BudgieInWA
Copy link

I agree that tabs go fine with a Drawer. I personally think the "repositories" list should have it's own screen.
Dashboard and Up Navigation Mockup
http://developer.android.com/design/patterns/navigation.html

Here's the mockup source as bmml for anyone who wants to play around or iterate.

@nwadams
Copy link

nwadams commented Jun 28, 2013

I like this idea. I have worked with the drawer before so I can start playing with this.

@atermenji
Copy link
Contributor

There is one problem with intergrating NavigationDrawer currently.
GitHubAndroid is using ActionBarSherlock and right now the support library has not been added to maven central.
See this issue for more info: JakeWharton/ActionBarSherlock#946

@BudgieInWA
Copy link

Perhaps in the interim, the existing "Gists", "Issues Dashboard" and "Bookmarks" views could have their Up buttons replaced with the same spinner that is on the "Home" view (that is named after the user). This suggests the same hierarchy as the drawer.

@Meisolsson
Copy link
Contributor

The old issue of not having the support lib has been fixed with the gradle implementation in #553. If that is merged we cab start to make the app a bit better.

@fadils
Copy link
Member

fadils commented Jan 7, 2015

Continued in #664

@fadils fadils closed this as completed Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants