Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licenses missing from sitemap #203

Closed
benbalter opened this issue Jun 16, 2014 · 6 comments
Closed

Licenses missing from sitemap #203

benbalter opened this issue Jun 16, 2014 · 6 comments

Comments

@benbalter
Copy link
Contributor

E.g., http://choosealicense.com/sitemap.xml

@parkr and idea why jekyll-sitemap wouldn't include the license files?

@parkr
Copy link

parkr commented Jun 16, 2014

@parkr and idea why jekyll-sitemap wouldn't include the license files?

They're not html files: https://github.com/jekyll/jekyll-sitemap/blob/master/lib/jekyll-sitemap.rb#L11

I'd suggest adding a field to the page which says:

---
title: Blah
sitemap:
  include: true

It's a little confusing ("isn't everything included?") but would allow you to carry on with just TXT files.

@benbalter
Copy link
Contributor Author

They're not html files:

Oh odd. Even though the permalink ends in an implied .html?

@parkr
Copy link

parkr commented Jun 17, 2014

Oh odd. Even though the permalink ends in an implied .html?

Right. Jekyll sees them as text files, and it asks the converter for this file (the identity converter in this case) what output extension the file will have and asks if it's .html. If not, it gets the 👢. We could also test the permalink attribute in jekyll-sitemap if you like!

Side question: why are the licenses .txt files rather than .html files in this repo, anyway?

@benbalter
Copy link
Contributor Author

Side question: why are the licenses .txt files rather than .html files in this repo, anyway?

Because the body is text, not HTML.

@benbalter
Copy link
Contributor Author

Fixed via jekyll/jekyll-sitemap#39

@parkr
Copy link

parkr commented Sep 5, 2014

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants