Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Course templates should directly create Actions Workflows #15

Closed
s0 opened this issue Jan 16, 2020 · 1 comment
Closed

Course templates should directly create Actions Workflows #15

s0 opened this issue Jan 16, 2020 · 1 comment
Assignees

Comments

@s0
Copy link
Contributor

s0 commented Jan 16, 2020

Learning Lab can't currently use course templates that directly create GitHub workflow files in .github/workflows. This is due to an access restriction. As CodeQL courses rely on being able to run actions to check participants's answers, we need to work around this.

Workaround

We create the actions workflows as needed, and then rename .github to .github.to.move.
We then instruct course creators to include instructions asking users

Once Fixed

  • Rename .github.to.move to .github in templates/learninglab/course-templates
  • Remove any step + check in the course asking the learner to do that and checking it
  • Update the instructions in templates/learninglab/README.md as appropriate.
  • All CodeQL courses should be updated to do the same thing.
@xcorail xcorail self-assigned this Apr 1, 2020
@xcorail
Copy link
Contributor

xcorail commented Apr 1, 2020

https://github.com/github/learning-lab/issues/2263#issuecomment-607317153
🎉
cc @adityasharad

@xcorail xcorail closed this as completed Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants