-
Notifications
You must be signed in to change notification settings - Fork 58.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODEOWNERS documentation claims that a user needs at least read access, but GitHub's built in linter claims the user needs write access #18984
Comments
@ScriptAutomate Thanks so much for opening an issue! I'll triage this for the team to take a look 👀 |
This comment was marked as spam.
This comment was marked as spam.
Thanks @ScriptAutomate, by coincidence this was actually just fixed internally and should be published shortly. 🙇🏻 |
Thanks! For documentation purposes: It looks like the error was in the documentation, which has since been fixed. It does mean that only users with Write access can be used in the CODEOWNERS file. New docs content:
Is there a route I can take for a feature request? With our open source project, we would love to be able to have community members with explicit Read or Triage permissions to be able to be assigned to review PRs (since I thought that is what Triage was for??). |
It would be nice to able to have people who can not merge code (write), be apart of the review/notification/approval process for a PR. |
Yes! You can provide product feedback here. Thanks for helping us improve GitHub! 💖 |
Related feature request has been opened: |
ScriptAutomate has submitted the request, @lecoursen can you please ensure it has the correct labels. Many thanks. |
👋🏻 @damon-atkins, the GitHub community discussions are owned by a different team. (We only own this repo and docs.github.com.) 💖 I'm sure the appropriate team will review the post shortly! 😊 |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
What part(s) of the article would you like to see updated?
I read this as:
The GitHub linter throws a
This CODEOWNERS file contains errors
message, for my users with at least read access, and says:The problem is:
I can't tell whether the docs are wrong or the GitHub linter is wrong. This is why I'm raising this issue here.
Additional information
Example from PR:
Problems:
@ryan-lane
existsRead
role to the repositoryRead
, at a minimum (thus alsoTriage
), should be enough for individualsThe text was updated successfully, but these errors were encountered: