Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document jobs.<job_id>.defaults.run.working-directory because it's important #31346

Closed
1 task done
jsoref opened this issue Jan 30, 2024 · 3 comments · Fixed by #31970
Closed
1 task done

Please document jobs.<job_id>.defaults.run.working-directory because it's important #31346

jsoref opened this issue Jan 30, 2024 · 3 comments · Fixed by #31970
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@jsoref
Copy link
Contributor

jsoref commented Jan 30, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iddefaultsrun

What part(s) of the article would you like to see updated?

There should be a jobs.<job_id>.defaults.run.working-directory

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iddefaultsrun
Says:

Use jobs.<job_id>.defaults.run to provide default shell and working-directory to all run steps in the job. This keyword can reference several contexts. For more information, see "Contexts."

That should be visible in the ToC on the right, and have proper paragraphs. I shouldn't have to read the entire document to discover this.

Additional information

It should explain how it interacts with previous levels.

There's a workflow that uses a global:

defaults:
  run:
    working-directory: ruby

I have no idea how to reset the working directory to the default in one job.

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Jan 30, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 30, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 30, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for opening an issue! I'll get this triaged for review ✨

@jsoref
Copy link
Contributor Author

jsoref commented Jan 30, 2024

Fwiw, jobs.<job_id>.defaults.run.working-directory does indeed work. But I shouldn't have had to guess.

@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while we reviewed this! 👋

The team agrees documenting jobs.<job_id>.defaults.run.working-directory would be valuable. You, or anyone else, are welcome to submit a PR with this fix 💛

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 5, 2024
@docs-bot docs-bot added this to Help wanted in Docs open source board Mar 5, 2024
Docs open source board automation moved this from Help wanted to Done Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue
Development

Successfully merging a pull request may close this issue.

2 participants