Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tables does not correctly shown in some translated pages. #4480

Closed
uzulla opened this issue Mar 12, 2021 · 4 comments
Closed

Some tables does not correctly shown in some translated pages. #4480

uzulla opened this issue Mar 12, 2021 · 4 comments
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team

Comments

@uzulla
Copy link

uzulla commented Mar 12, 2021

What is the current behavior?

Some table does not appear to be correctly in some translated page.

ex: https://docs.github.com/ja/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization

When old commit( 01b5d89 ) seems no problem.

at en ( no problem)

image

at ja

image

at cn

image

What changes are you suggesting?

Add lost tail | and fix {% endif %} position (s/**X** \n/**X** |{% endif %}\n/).

image

ng (now)

| 公開済みリリースの表示                                                                                                                                                                                                         | **X** | **X**  | **X** |  **X**   |                                              **X** |{% if currentVersion == "free-pro-team@latest" %}
| [[GitHub Actions workflow runs](/actions/automating-your-workflow-with-github-actions/managing-a-workflow-run)] の表示                                                                                                 | **X** | **X**  | **X** |  **X**   |                                                                 **X** 
{% endif %}

(maybe) ok

| 公開済みリリースの表示                                                                                                                                                                                                         | **X** | **X**  | **X** |  **X**   |                                              **X** |{% if currentVersion == "free-pro-team@latest" %}
| [[GitHub Actions workflow runs](/actions/automating-your-workflow-with-github-actions/managing-a-workflow-run)] の表示                                                                                                 | **X** | **X**  | **X** |  **X**   |                                                                 **X** |{% endif %}

Fixed rendering sample ( my local env )

image

(I tought make fix pull-request. But protocols of fixing translate docs are seems not simple 🙄 )

Additional information

@uzulla uzulla added the engineering Will involve Docs Engineering label Mar 12, 2021
@welcome
Copy link

welcome bot commented Mar 12, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 12, 2021
@github-actions github-actions bot added this to Triage in Docs open source board Mar 12, 2021
@hainusii

This comment has been minimized.

@janiceilene janiceilene moved this from Triage to Engineering review needed in Docs open source board Mar 16, 2021
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue @uzulla! This has been triaged for the engineering team to take a look 👀

@rachmari
Copy link
Contributor

This was just fixed. You should see the update live within 24 hours. However, the next time that page is automatically updated, the bug will reappear. I've filed an internal issue requesting a fix in our translation memory to fix this permanently.

Docs open source board automation moved this from Engineering review needed to Done Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team
Development

No branches or pull requests

4 participants