filereader fix and form data change #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reject(reader.error) | ||
| } | ||
| reader.readAsText(blob) | ||
| var reader = new FileReaderSync() |
There was a problem hiding this comment.
I don't think anyone has implemented FileReaderSync yet.
There was a problem hiding this comment.
hmm.. gecko has had it for a while now. oh right, i completely forgot this code is shared by window :/
| // FileReader is not available on Workers in Firefox, but FileReaderSync | ||
| // is. | ||
| var reader | ||
| if (typeof FileReaderSync !== "undefined") { |
There was a problem hiding this comment.
shouldn't you check for FileReader first instead, to use the async version when both are available ?
|
I'm not sure why the travis build failed. I won't be able to fix this until next week, so feel free to steal. |
| reader.onerror = function() { | ||
| reject(reader.error) | ||
| var reader | ||
| if (typeof FileReaderSync !== "undefined") { |
There was a problem hiding this comment.
this should use single quotes (in both places) to fix the JSHInt warnings which are making the build fail
|
Thanks @nikhilm. I was able to cherry pick these changes into master with the linting tests fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.