-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept PAT's as cli args in addition to env vars #4
Comments
For
|
Why can't we just pull the PATs from the env variables? |
Of course we can, but this issue is to support passing them as command args. So I was just wondering what the desired behavior in for |
so if I think about why I wanted to do this work, it's to make things more easy/convenient for people that don't want to mess around with how to set env variables, and just want to pass everything on the command-line. I would say if they pass them on the command line for generate script, then the generated script should work without needing them to manually set env vars. I see 3 options that I think would both be fine IMO:
In 1/2 cases the generated script will contain their secrets, I would suggest having generate-script spit out a warning making them aware of that fact. I would probably lean towards whichever of these is the easiest to implement, which has to be 3. |
Yup 3 is the easiest to implement given the fact that if a CLI command has more than 16 args then we cannot use the |
I did this as env vars to start because it's usually a more convenient way to pass around secrets, especially if you may be screen sharing while using the CLI. And you definately don't want secrets to be included in the generated script from the generate-script command.
For convenience though, an option to specify them directly as CLI args would be a nice addition.
The text was updated successfully, but these errors were encountered: