Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT work on mysql 5.5 #184

Closed
nilly opened this issue Aug 23, 2016 · 5 comments
Closed

NOT work on mysql 5.5 #184

nilly opened this issue Aug 23, 2016 · 5 comments
Assignees
Labels

Comments

@nilly
Copy link

nilly commented Aug 23, 2016

test on mysql 5.5.9

gh-ost \
--max-load=Threads_running=25 \
--critical-load=Threads_running=1000 \
--chunk-size=1000 \
--throttle-control-replicas="127.0.0.1,127.0.0.1" \
--max-lag-millis=1500 \
--user="root" \
--password="" \
--host=127.0.0.1 \
--allow-on-master \
--database="test" \
--table="lsl" \
--verbose \
--alter="engine=innodb" \
--switch-to-rbr \
--allow-master-master \
**--allow-nullable-unique-key \**
--cut-over=default \
--exact-rowcount \
--default-retries=120 \
--panic-flag-file=/tmp/ghost.panic.flag \
--postpone-cut-over-flag-file=/tmp/ghost.postpone.flag \


2016-08-23 11:01:02 INFO Chosen shared unique key is idx_id1
2016-08-23 11:01:02 WARNING Chosen key (idx_id1: [id1]; has nullable: true) has nullable columns. You have supplied with --allow-nullable-unique-key and so this migration proceeds. As long as there aren't NULL values in this key's column, migration should be fine. NULL values will corrupt migration's data
2016-08-23 11:01:02 FATAL binlog_row_image is '' and chosen key is idx_id1: [id1]; has nullable: true, which is not the primary key. This operation cannot proceed. You may `set global binlog_row_image='full'` and try again

BUT mysql 5.5.9 has no this global variable binlog_row_image

and I have already use --allow-nullable-unique-key

@nilly nilly changed the title ongly support mysql 5.6.x ?? NOT work on mysql 5.5.9 Aug 23, 2016
@shlomi-noach
Copy link
Contributor

True, binlog_row_image was only introduced in 5.6.2. Will fix.

@shlomi-noach shlomi-noach self-assigned this Aug 23, 2016
@shlomi-noach
Copy link
Contributor

Seems like I did foresee this: https://github.com/github/gh-ost/blob/master/go/logic/inspect.go#L300
checking what went wrong.

@shlomi-noach
Copy link
Contributor

Fixed by #200

@shlomi-noach shlomi-noach changed the title NOT work on mysql 5.5.9 NOT work on mysql 5.5 Aug 25, 2016
@shlomi-noach
Copy link
Contributor

Will likely publish a release tomorrow that will include this fix.

@shlomi-noach
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants