Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illegal character U+005F '_' #198

Closed
tozhengxq opened this issue Aug 25, 2016 · 4 comments
Closed

illegal character U+005F '_' #198

tozhengxq opened this issue Aug 25, 2016 · 4 comments
Assignees

Comments

@tozhengxq
Copy link

tozhengxq commented Aug 25, 2016

when some config items contains '_' (like "sync_binlog = 1")in the conf file (conf="/tmp/my1.cnf"),it will error and stack print:

2016-08-25 17:19:26 FATAL /tmp/my1.cnf:62:4: illegal character U+005F '_'
goroutine 1 [running]:
runtime/debug.Stack(0x0, 0x0, 0x0)
        /usr/local/go/src/runtime/debug/stack.go:24 +0x80
runtime/debug.PrintStack()
        /usr/local/go/src/runtime/debug/stack.go:16 +0x18
github.com/github/gh-ost/vendor/github.com/outbrain/golib/log.logErrorEntry(0x0, 0x7feaa45a78d0, 0xc820010ca0, 0x0, 0x0)
        /Users/zhengxq/go/src/github.com/github/gh-ost/vendor/github.com/outbrain/golib/log/log.go:178 +0x159
github.com/github/gh-ost/vendor/github.com/outbrain/golib/log.Fatale(0x7feaa45a78d0, 0xc820010ca0, 0x0, 0x0)
        /Users/zhengxq/go/src/github.com/github/gh-ost/vendor/github.com/outbrain/golib/log/log.go:255 +0x40
main.main()
        /Users/zhengxq/go/src/github.com/github/gh-ost/go/cmd/gh-ost/main.go:161 +0x139b
@shlomi-noach
Copy link
Contributor

Fixed in #199

@shlomi-noach
Copy link
Contributor

The issue should only be closed once the PR is merged :)

@shlomi-noach
Copy link
Contributor

Closed by #199

@shlomi-noach
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants