Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the race condition regarding
$HOME
in the integration tests.Now, an initial
$TESTHOME
is setup at$REMOTEDIR/home
. It has the starting git config and OSX keychain (if needed).begin_test()
resets$HOME
to$TRASHDIR/home
, which is unique per test script. Tests run sequentially in a single script.I also ran into an issue where
begin_test()
was silently failing, causing the scripts to bail after the first test. So, I added something inshutdown()
that ensures every test runs by grepping the file for allbegin_test()
calls.