Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ubuntu specific hacks #32

Closed
lmb opened this issue Aug 13, 2018 · 3 comments
Closed

Remove Ubuntu specific hacks #32

lmb opened this issue Aug 13, 2018 · 3 comments

Comments

@lmb
Copy link
Contributor

lmb commented Aug 13, 2018

glb-redirect has some sort of compatibility hack in it's source: https://github.com/github/glb-director/blob/master/src/glb-redirect/libxt_GLBREDIRECT.c#L25-L27

This breaks building on arm64 which I'm currently looking into. Are these hacks still required? Is it possible to gate them just to Ubuntu?
@lmb
Copy link
Contributor Author

lmb commented Aug 20, 2018

@theojulienne do you have any insight on this?

@theojulienne theojulienne mentioned this issue Aug 20, 2018
Merged
@theojulienne
Copy link
Contributor

Sorry for the delay here!

👍 Since Precise is EOL, I think it's reasonable to remove those special cases. I've filed #36 to remove them.

Did you find removing those lines was enough to get it to compile on arm64?

@lmb
Copy link
Contributor Author

lmb commented Aug 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theojulienne @lmb