Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can support for Open in new tab ? #35

Closed
dnknn opened this issue Aug 7, 2020 · 2 comments
Closed

Can support for Open in new tab ? #35

dnknn opened this issue Aug 7, 2020 · 2 comments

Comments

@dnknn
Copy link

dnknn commented Aug 7, 2020

For details, please click to seeing to 馃憞
Mottie/GitHub-userscripts#123

@muan
Copy link
Contributor

muan commented Aug 7, 2020

hotkey simply calls click, so this is not its concern. Where a link is opened should be handled by the element it clicks on, for example, <a target="_blank">.

hotkey/src/utils.ts

Lines 16 to 22 in 0691586

export function fireDeterminedAction(el: HTMLElement): void {
if (isFormField(el)) {
el.focus()
} else {
el.click()
}
}

@muan muan closed this as completed Aug 7, 2020
@dnknn
Copy link
Author

dnknn commented Aug 7, 2020

Thank you very much for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants