[v2] git commit --amend -m "": errors now: error: switch `m' requires a value

[blueyed]

In hub 2, git commit --amend -m "" stopped working:

error: switch `m' requires a value
usage: git commit [options] [--] <pathspec>...

git version 2.1.0
hub version 2.2.0-preview1-66-ga16a121

Using git directly works.

It seems to not bypass empty shell arguments properly.

[mislav]

Good catch, thanks for letting us know!

Git itself is also supposed to fail when an empty commit message is given, but its error message should be: "Aborting commit due to empty commit message." This is obviously a case of us not forwarding command-line arguments correctly.

[blueyed]

Git does not fail, but re-uses the last message (at least with --amend).

I am using this alias/function, which results in an empty arg always at the end:

alias gcma='noglob _nomatch command_with_files "git commit --amend -m"'
command_with_files() {
  local cmd=$1; shift
  # Shift existing files/dirs from the beginning of args.
  files=()
  while (( $# > 0 )) && [[ -e $1 ]]; do
    files+=($1)
    shift
  done

  printf '%s\n' $=cmd "$*" $files
  $=cmd "$*" $files
}

[owenthereal]

Good catch! I attempted a fix in #727. The Args file is a bit of a mess now. I already have a better design in mind. Will do that in another PR.

[mislav]

Git does not fail, but re-uses the last message (at least with --amend).

You can also try git commit --amend -C HEAD

[blueyed]

Yes, and for that particular case git commit --amend --no-edit works also.

But the point of my alias is to provide an optional argument (which could be fixed/worked around), but that wouldn't have shown this bug.. ;)

[owenthereal]

@blueyed The fixes have been merged into master. Please update. I'm closing the issue. Feel free to reopen if it still happens.