Added secure option to use a secure port other than 6697 #162
Conversation
| @@ -34,6 +34,7 @@ class IrcBot extends Robot.Adapter | |||
| server: process.env.HUBOT_IRC_SERVER | |||
| password: process.env.HUBOT_IRC_PASSWORD | |||
| nickpass: process.env.HUBOT_IRC_NICKSERV_PASSWORD | |||
| secure: process.env.HUBOR_IRC_SECURE or false | |||
There was a problem hiding this comment.
Can we call this HUBOT_IRC_SSL_PORT or something similar instead?
There was a problem hiding this comment.
That might lead people to think that it's supposed to be a port instead of a boolean, don't you think?
There was a problem hiding this comment.
Personally I like HUBOT_IRC_SECURE as it maps to the option in node-irc.
|
Damn, I was doing some hacking on the repo and I din't realize it would show up on the pull request. |
|
Fixed in #175. |
…ash-with-alias Add --alias (--enable-slash is deprecated)
|
It's not fixed.
What if I want to use an ssl connection on a port other than 6697? That "and" should have been an "or". Also, statements like this:
don't work as expected (or at least I wasn't able to make them work). If I set the environment variable to the value True, the string "True" will be compared to false. Any non-empty string is evaluated to true, therefore the string "True" will be sent to the irc constructor which was expecting a boolean, and the option will be ignored. The !! operator should be used instead to assert that the env variable was set. Please correct me if I'm wrong. |
Add support for host/port configuration in the XMPP adapter.
|
Can you update this pull to fix those issues, then I'll merge it in? |
…any guesses as to whether the port is secure or not.
|
Done. |
|
Cool nice one. :) |
Added secure option to use a secure port other than 6697
Added secure option to use a secure port other than 6697
No description provided.