Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In NuGet source, consider downloading licenseUrl even if license already known from file or expression #270

Open
zarenner opened this issue May 15, 2020 · 0 comments

Comments

@zarenner
Copy link
Contributor

Currently, we only download the nuspec's <licenseUrl> if we weren't able to determine the license in another way. That is, if we matched on a license file, <license type="expression">, or well-known <licenseUrl>, we don't download.

It's not clear that this is reasonable - for instance, what if the license text at <licenseUrl> doesn't match the same license as <license> or a LICENSE.txt? We should report other in those cases, but today we would report the license expression and/or file.

Like #269, this may require changes to licensee to better indicate if <license> and <licenseUrl> aren't guaranteed to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant