Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Pygments dependency #1707

Merged
merged 7 commits into from Nov 14, 2014
Merged

Remove the Pygments dependency #1707

merged 7 commits into from Nov 14, 2014

Conversation

vmg
Copy link
Contributor

@vmg vmg commented Nov 13, 2014

This PR removes the Pygments dependency on Linguist.

cc @aroben @bkeepers

@aroben
Copy link
Contributor

aroben commented Nov 13, 2014

This probably needs to be v4.0 since it breaks compatibility right?

@vmg
Copy link
Contributor Author

vmg commented Nov 13, 2014

Meh, semver is a dumb concept overall. I'm not opposed to bumping the major version anyway. @bkeepers are you OK with it?

@aroben
Copy link
Contributor

aroben commented Nov 13, 2014

I think we can remove all the lexer attributes in the YAML file too.

Meh, semver is a dumb concept overall. I'm not opposed to bumping the major version anyway. @bkeepers are you OK with it?

I think we need to bump it so people specifying gem "linguist", "~>3.5" don't end up with an incompatible version.

@vmg
Copy link
Contributor Author

vmg commented Nov 13, 2014

Word. Gonna clean the yaml.

@pchaigno
Copy link
Contributor

There should maybe be some documentation on the new syntax highlighting(?). Many people come here with questions and issues about this.

vmg pushed a commit that referenced this pull request Nov 14, 2014
Remove the Pygments dependency
@vmg vmg merged commit 75871e5 into master Nov 14, 2014
@qerub
Copy link

qerub commented Nov 16, 2014

Any chance GitHub could use a version without this change until #1721, #1717, #1670 and perhaps more are resolved?

@vmg
Copy link
Contributor Author

vmg commented Nov 16, 2014

I'm afraid that's not an option. :)

@aroben
Copy link
Contributor

aroben commented Nov 17, 2014

@qerub The main problem with rolling back to Pygments is that we wouldn't discover any more of these issues, and thus wouldn't be able to fix them. We're working to fix these problems as quickly as they're discovered, but it just isn't possible to find all the bugs with these grammars without using them live on github.com. Sorry for the inconvenience in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants