New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Pygments dependency #1707
Conversation
a8c3480
to
c5af1d3
Compare
This probably needs to be v4.0 since it breaks compatibility right? |
Meh, semver is a dumb concept overall. I'm not opposed to bumping the major version anyway. @bkeepers are you OK with it? |
I think we can remove all the
I think we need to bump it so people specifying |
Word. Gonna clean the yaml. |
There should maybe be some documentation on the new syntax highlighting(?). Many people come here with questions and issues about this. |
2b9eb4e
to
51b16ca
Compare
I'm afraid that's not an option. :) |
@qerub The main problem with rolling back to Pygments is that we wouldn't discover any more of these issues, and thus wouldn't be able to fix them. We're working to fix these problems as quickly as they're discovered, but it just isn't possible to find all the bugs with these grammars without using them live on github.com. Sorry for the inconvenience in the meantime. |
This PR removes the Pygments dependency on Linguist.
cc @aroben @bkeepers