Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository is being misclassified as CSS instead of TypeScript #3726

Closed
jasalazar opened this issue Jul 20, 2017 · 5 comments
Closed

Repository is being misclassified as CSS instead of TypeScript #3726

jasalazar opened this issue Jul 20, 2017 · 5 comments

Comments

@jasalazar
Copy link

captura de pantalla de 2017-07-20 17 50 55

My repository has only 4 CSS files, and 23 TypeScript files, however it is classified as a CSS repo.

What could be the reason?

@pchaigno
Copy link
Contributor

This is happening because of these files:

src/assets/font-awesome/less/animated.less
src/assets/font-awesome/less/bordered-pulled.less
src/assets/font-awesome/less/core.less
src/assets/font-awesome/less/fixed-width.less
src/assets/font-awesome/less/icons.less
src/assets/font-awesome/less/larger.less
src/assets/font-awesome/less/list.less
src/assets/font-awesome/less/mixins.less
src/assets/font-awesome/less/path.less
src/assets/font-awesome/less/rotated-flipped.less
src/assets/font-awesome/less/screen-reader.less
src/assets/font-awesome/less/stacked.less
src/assets/font-awesome/less/variables.less
src/assets/font-awesome/scss/_animated.scss
src/assets/font-awesome/scss/_bordered-pulled.scss
src/assets/font-awesome/scss/_core.scss
src/assets/font-awesome/scss/_fixed-width.scss
src/assets/font-awesome/scss/_icons.scss
src/assets/font-awesome/scss/_larger.scss
src/assets/font-awesome/scss/_list.scss
src/assets/font-awesome/scss/_mixins.scss
src/assets/font-awesome/scss/_path.scss
src/assets/font-awesome/scss/_rotated-flipped.scss
src/assets/font-awesome/scss/_screen-reader.scss
src/assets/font-awesome/scss/_stacked.scss
src/assets/font-awesome/scss/_variables.scss
src/styles.css

Maybe we should consider the whole font-awesome directory vendored...?

@jasalazar
Copy link
Author

Probably, @pchaigno . Should I do anything with the directory?

@pchaigno
Copy link
Contributor

I'll make a pull request to mark the font-awesome directory vendored. What types of files can be found in this directory? .scss, .less, anything else?

In the meantime, you can mark those files as vendored using Linguist overrides.

@lildude
Copy link
Member

lildude commented Dec 2, 2017

@pchaigno
Copy link
Contributor

pchaigno commented Dec 2, 2017

Actually, I forgot to send the pull request. We need to vendor the whole font-awesome directory. #3932 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants