Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia syntax #5087

Closed
pfitzseb opened this issue Nov 8, 2020 · 5 comments
Closed

Update Julia syntax #5087

pfitzseb opened this issue Nov 8, 2020 · 5 comments

Comments

@pfitzseb
Copy link

pfitzseb commented Nov 8, 2020

The 0.20 release of language-julia has a critical bug that breaks highlighting for basically every file (e.g. this). This wasn't caught in our tests because those run with Oniguruma instead of PCRE.

0.20.1 fixes the bug (verified with lightshow), so it would be great if we could get a patch release to un-break syntax highlighting on GitHub without having to wait for month or so :)

Thanks and sorry for the trouble!

@lildude lildude mentioned this issue Nov 9, 2020
3 tasks
@lildude
Copy link
Member

lildude commented Nov 9, 2020

No probs. I've pulled this into v7.12.1 which I'm in the process of releasing right now.

@pfitzseb
Copy link
Author

pfitzseb commented Nov 9, 2020

Thanks a bunch!

Related: Do you have any pointers on how to run (regression) tests against GitHub's syntax highlighting pipeline? I'd rather not have to check lightshow for each PR...

@lildude
Copy link
Member

lildude commented Nov 9, 2020

Do you have any pointers on how to run (regression) tests against GitHub's syntax highlighting pipeline?

Unfortunately not. @Alhadis might have some ideas as he maintains a few grammars.

@lildude
Copy link
Member

lildude commented Nov 9, 2020

The latest Julia grammar is now in use on GitHub.com. Current files are cached so their syntax highlighting won't change until there is a push to each repo.

https://gist.github.com/lildude/13b6fe9e3afc45db47e801ec53984619 is an example of what the file you originally referenced will look like once the repo is reanalysed.

Closing.

@lildude lildude closed this as completed Nov 9, 2020
@pfitzseb
Copy link
Author

pfitzseb commented Nov 9, 2020

Current files are cached so their syntax highlighting won't change until there is a push to each repo.

Is that only the case for patch releases or why did the broken grammar get applied for all files, not just those that were modified since Friday? Ah, nvm, there actually was a commit to the repo I was checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants