Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language: Imba #5910

Closed
familyfriendlymikey opened this issue May 25, 2022 · 5 comments
Closed

Add Language: Imba #5910

familyfriendlymikey opened this issue May 25, 2022 · 5 comments
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist

Comments

@familyfriendlymikey
Copy link
Contributor

familyfriendlymikey commented May 25, 2022

Language name

Imba

URL of example repository

Imba.io repository

URL of syntax highlighting grammar

Imba's vscode extension

Most popular extensions

.imba

Detected language

Plain text

Popularity

Pull Request Information

  • Here's my fork, grammar compilation failed citing several PCRE errors, despite syntax highlighting working in VSCode.
  • Here's the source of the provided sample, MIT license.

Next Steps

In CONTRIBUTING.md it says

If problems are found, please report them to the grammar maintainer

I would very much appreciate some guidance on next steps. Thank you.

@familyfriendlymikey familyfriendlymikey added Add Language Good First Issue This is a great opportunity to start contributing to Linguist labels May 25, 2022
@codeluggage
Copy link

There are 2,864 .imba files on GitHub.

I wonder how many files would show up if private repos could be counted too.

Also, as Imba requires much less configuration, and can express styling, markup and logic in a single language (and thus, a single file), the number of Imba files will always be "artifically low".

Crossing my fingers Imba can be included soon! 🤞 🤞

@MystPi
Copy link

MystPi commented Jun 10, 2022

And I was about to suggest Imba too. Cool!

@lildude
Copy link
Member

lildude commented Jun 10, 2022

I would very much appreciate some guidance on next steps. Thank you.

Sure...

Here's my fork, grammar compilation failed citing several PCRE errors, despite syntax highlighting working in VSCode.

If you're seeing errors it's because you're using Oniguruma-specific expressions and/or are using very long expressions. This should be clear in the errors. These work on VSCode because it uses that regex engine which isn't particularly strict, however GitHub uses PCRE for performance reasons. In order to resolve those, you'll need to switch out the Oniguruma-specific expressions for PCRE-compatible expressions and ensure your expressions aren't too long and adhere to PCRE's limits.

@somebee
Copy link

somebee commented Aug 12, 2022

@familyfriendlymikey Maybe you could try pointing at

path = vendor/grammars/language-imba
url = https://github.com/somebee/language-imba

Instead of

path = vendor/grammars/vscode-imba
url = https://github.com/imba/vscode-imba.git

And see if it passes then? Would love to see imba included at some point!

@familyfriendlymikey
Copy link
Contributor Author

@lildude Thank you very much for explaining. I've fixed the expressions and submitted a PR: #6080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist
Projects
None yet
Development

No branches or pull requests

5 participants