Detection by extension made case-insensitive #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've always thought this was weird. @bkeepers this seems like a good idea to me? |
|
👍 |
arfon
added a commit
that referenced
this pull request
Feb 27, 2015
Detection by extension made case-insensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of an idea @larsbrinkhoff suggested in #2072.
With this pull request the search by file extensions is case-insensitive.
I wanted to see if it creates any issue with the detection.
It actually solves a few incorrect detections and I think it globally makes sense:
For instance, all
.efiles in the Rosetta project are detected as Eiffel but most of them are actually E code.With this pull request the detection results get a lot better.
In general, it looks like lower-case and upper-case extensions are regularly mixed. See #2072, #308, #268 or #1035 for examples.