Add Unity3D Asset and Metadata files #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - .unity | ||
| tm_scope: source.yaml | ||
|
|
||
| Unity3D Metadata: |
There was a problem hiding this comment.
Why do you want to make a separate language for Unity3D Metadata? It looks like it has the same YAML syntax as the other files...
There was a problem hiding this comment.
Hmm, good point. I'll fold it in.
|
@pchaigno Updated with *.meta as part of the Unity3D Asset language definition. |
| # Return true or false | ||
| def generated_unity3d_meta? | ||
| return false unless extname == '.meta' | ||
| return lines[0].include?("fileFormatVersion: ") |
There was a problem hiding this comment.
I think you should check for the number of lines: return false unless lines.count > 1
|
Thanks for this @mephaust. For good housekeeping would you mind adding an example file for each of the extensions as you have for |
|
@arfon Added more samples. |
|
👍 thanks @mephaust. This looks good to go. |
arfon
added a commit
that referenced
this pull request
May 13, 2015
Add Unity3D Asset and Metadata files
|
These changes should be live in GitHub on the next release of Linguist |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of in-the-wild usage on GitHub: