Limit scope of modeline search #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * Author: John Ellis | ||
| * | ||
| * This software is released under the GNU General Public License (GNU GPL). |
There was a problem hiding this comment.
Any chance you can find a non-GPL example @pchaigno?
There was a problem hiding this comment.
Found one! :D Or rather, edited one, after having cleaned up Google's crap code style.
GitHub: 1
GPL: 0
I AM THE THORN IN THE ARSE OF RICHARD STALLMAN.
There was a problem hiding this comment.
@Alhadis Thanks! I've updated the pull request with this sample.
Only matches the first and last 5 lines against the modeline regular expressions
pchaigno
force-pushed
the
limit-scope-modeline
branch
from
0ebbb3a
to
e8616f6
Compare
|
👍 thanks both. |
This was referenced Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request limits the scope of the modeline search on files, as discussed in #2942.
It now only matches the first and last 5 lines against the modeline regular expressions.
Fixes #2942.