Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with filenames ending with a dot #3349

Merged
merged 1 commit into from Nov 29, 2016

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Nov 26, 2016

Blob.extensions() returns a non empty extension for files ending with a dot. For instance,

new Blob("K.U.S.H.", "").extensions => [".u.s.h", ".s.h", ".h"]

This pull request fixes that behavior.

Fixes #3348.

The second negative argument to split instructs it to
preserve null fields in the returned array
@pchaigno pchaigno added the Bug label Nov 26, 2016
@brndnblck brndnblck merged commit 1d2ec4d into github-linguist:master Nov 29, 2016
@pchaigno pchaigno deleted the fix-extension-extraction branch November 29, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A dot at the end of file name
2 participants