Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PAWN to Pawn #4305

Merged
merged 5 commits into from Oct 29, 2018
Merged

Rename PAWN to Pawn #4305

merged 5 commits into from Oct 29, 2018

Conversation

X6B0ISI09wD4
Copy link
Contributor

This PR renames the language labeled as PAWN to Pawn. The reasons were originally outlined in #3156 (comment). Although the language is sometimes (incorrectly) referred to as PAWN on game forums its real name is in fact Pawn.

Description

This is hopefully the first part of closing out #3156.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pawn was added by @GiampaoloFalqui in #885, but the name change was requested before in #2512 by @ziggi (back when we couldn't change language names), so I'd say we're good to go!

If anyone thinks Pawn should stay PAWN, please argue here now before we merge.

@GiamPy5
Copy link
Contributor

GiamPy5 commented Oct 24, 2018

I disagree on the rename, the official website clearly shows PAWN all uppercase.

https://www.compuphase.com/pawn/pawn.htm

@ziggi
Copy link
Contributor

ziggi commented Oct 24, 2018

But in official Pawn repository everywhere (readme.txt, LICENSE) used Pawn as name: https://github.com/compuphase/pawn

@GiamPy5
Copy link
Contributor

GiamPy5 commented Oct 24, 2018

But in official Pawn repository everywhere (readme.txt, LICENSE) used Pawn as name: https://github.com/compuphase/pawn

Well, I guess you're right, Pawn it is!

@X6B0ISI09wD4
Copy link
Contributor Author

@GiampaoloFalqui seems that's just the styling they've gone for to highlight the language's name on that page.

<span class="smallCaps" style="font-family:Arial,Helvetica,Swiss,sans-serif;">pawn</span>

Even the title tag of the page has it cased as Pawn.

<title>The Pawn language</title>

@lildude lildude merged commit db1796c into github-linguist:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants