Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stalebot #4311

Merged
merged 2 commits into from Nov 5, 2018
Merged

Add stalebot #4311

merged 2 commits into from Nov 5, 2018

Conversation

lildude
Copy link
Member

@lildude lildude commented Nov 2, 2018

@pchaigno has been doing a marvellous job of marking old issues and PRs stale but I feel this is a waste of his skills. Lets outsource this to a robot: stalebot.

The app has been added to the repo, so we just need to configure it - this PR.

I've gone with the default daysUntil* values as they seem like a good place to start.

Template removed as it's not relevant.

@Alhadis
Copy link
Collaborator

Alhadis commented Nov 2, 2018

Flagging as stale.

@Alhadis Alhadis added the Stale label Nov 2, 2018
@Alhadis
Copy link
Collaborator

Alhadis commented Nov 2, 2018

Wait, that's a really good idea.

14 hours of code review make John go loopy-loopy. 👍

@Alhadis Alhadis removed the Stale label Nov 2, 2018
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on writing a Probot for that! I should have known someone already wrote one...

LGTM, even though I would have gone for a shorter time period before marking issues and PRs as stale.

.github/stale.yml Outdated Show resolved Hide resolved
@pchaigno
Copy link
Contributor

pchaigno commented Nov 2, 2018

Do we have a way to know which issues and pull requests will be affected when the pull request is merged?

@lildude
Copy link
Member Author

lildude commented Nov 2, 2018

Do we have a way to know which issues and pull requests will be affected when the pull request is merged?

Yup. Just add updated:<YYYY-MM-DD and multiple -label:"label name" filters to the issues or PRs pages, where YYYY-MM-DD is the date daysUntilStale before today and -label are the labels you want to exclude.

If we go for 30 days with the current label choice, these issues and these PRs are affected.

@lildude lildude merged commit e6bc694 into master Nov 5, 2018
@lildude lildude deleted the lildude/stalebot branch November 5, 2018 11:07
@pchaigno
Copy link
Contributor

pchaigno commented Nov 5, 2018

@lildude I haven't seen any changes in the issues and pull requests mentioned above. Are there still things that need to be configured to enable Probot, or will it only start labeling issues in 30 days?

@lildude
Copy link
Member Author

lildude commented Nov 5, 2018

@lildude I haven't seen any changes in the issues and pull requests mentioned above. Are there still things that need to be configured to enable Probot, or will it only start labeling issues in 30 days?

🤔 I don't think there's anything more to do after merging the PR. I'd expect things to come to life within the next 24 hours.

@pchaigno
Copy link
Contributor

pchaigno commented Nov 6, 2018

And the storm begins... Maybe we could exclude issues and pull requests that have been assigned to one of us? Many of the now stale-marked issues are actually blocked because one of us (maintainers) needs to do something.

@lildude
Copy link
Member Author

lildude commented Nov 6, 2018

Maybe we could exclude issues and pull requests that have been assigned to one of us?

Doesn't look like it has this functionality yet so the only thing to do would be use a label for the mo. Of course, the nudge should apply to us too - I often forget about my assigned PRs and issues 😀

@pchaigno
Copy link
Contributor

pchaigno commented Nov 6, 2018

Doesn't look like it has this functionality yet

Looks like we're in luck: probot/stale#172.

@lildude
Copy link
Member Author

lildude commented Nov 6, 2018

Wow!!! What timing. Less than 24 hours after we started using stalebot 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants