Use correct scope for Razor-plus grammar #4322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst generating and testing the upcoming v7.1.0 release I noticed that the cshtml/razor change in #4314 introduced the wrong scope for the grammar and this is picked up by the grammar compiler:
The correct scope is
text.html.cshtml
as the error reports and can be confirmed by checking the grammar itself. This PR corrects the scope as using the wrong scope results in no syntax highlighting at all.This would have been picked up by the
script/add-grammar
script that should have been used to replace the grammar. I suspect it wasn't, hence this slipped through.Checklist:
A quick review on this would be ✨ so I can get the release back into testing today.
/cc @worldbeater FYI as the author of #4314