Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting for svelte #4504

Merged
merged 11 commits into from May 28, 2019
Merged

Conversation

umanghome
Copy link
Contributor

@umanghome umanghome commented Apr 23, 2019

Resolves #4321 by adding syntax highlighting to .svelte files. Reopening after changes made to #4323.

Description

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@lildude
Copy link
Member

lildude commented Apr 23, 2019

As just discovered and mentioned in #4481, Travis CI doesn't support draft PRs yet, so once this is ready to go, you'll either need to push another commit after making this a real PR or we'll need to close and re-open it to trigger the build.

@umanghome umanghome marked this pull request as ready for review April 23, 2019 09:35
@umanghome
Copy link
Contributor Author

This PR should be squash-merged.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Could you please fill in the template? It is missing a correct link to in-the-wild search results and information on the added sample file. The Travis-CI build failure is also legit and should be addressed.

@umanghome
Copy link
Contributor Author

@pchaigno I've updated the PR, let me know if it's still missing anything.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the template, however it's missing one thing: the source of the sample file, which is also the reason I'm requesting a change on this PR. Your sample file looks like a very simple "hello world" example. No one uses "hello world" in production 😉 and they're not good for Linguist as they're terrible examples for training the classifier.

Can you please replace this with an appropriately licensed real-world example that makes a good representation of real usage, and link to the source in the template.

@umanghome
Copy link
Contributor Author

@lildude I've added another example. Let me know if it's still trivial, I'll ask someone from the community to add one.

@lildude
Copy link
Member

lildude commented May 15, 2019

@umanghome looks good to me. Thanks.

@lildude lildude requested review from lildude and pchaigno May 15, 2019 14:13
@lildude lildude requested a review from Alhadis May 28, 2019 09:43
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@lildude lildude dismissed their stale review May 28, 2019 09:59

Changes have been implemented.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Highlighting support for Svelte.
4 participants