Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL language #4805

Merged
merged 12 commits into from Mar 9, 2020
Merged

Add CodeQL language #4805

merged 12 commits into from Mar 9, 2020

Conversation

rewinfrey
Copy link
Contributor

@rewinfrey rewinfrey commented Feb 26, 2020

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @rewinfrey!

I have only one comment below, regarding the second file extension. I was also wondering if these files are of the same language?

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@rewinfrey
Copy link
Contributor Author

I was also wondering if these files are of the same language?

@pchaigno the first file in that query you provided is a .ql file that should be identified as QL, but the others are not. form is not a keyword in QL but can be used as a variable name (as seen in the first .ql file in the search query).

@pchaigno
Copy link
Contributor

pchaigno commented Mar 3, 2020

Thanks for the answers and updated pull request!

@pchaigno the first file in that query you provided is a .ql file that should be identified as QL, but the others are not.

We'll need to identify the language(s) of those files. If there are enough, we'll need to add support for those languages in Linguist. Otherwise, all those files are going to be identified as QL.

What about these files?

@maxbrunsfeld
Copy link

What about these files?

All of those files (at least the first 5 pages) are QL 👍 .

@maxbrunsfeld
Copy link

We'll need to identify the language(s) of those files. If there are enough, we'll need to add support for those languages in Linguist. Otherwise, all those files are going to be identified as QL.

It looks like for those files, the language that has been invented as an assignment for a programming class at a Dutch university.

The goal of this assignment is to build a DSL for questionnaires, called QL. QL allows you to define simple forms with conditions and computed values.

Source: the readme in https://github.com/EdwinOuwehand/ql-dsl.

I think that these other two repos in your search results are related to the same university course:
https://github.com/software-engineering-amsterdam/multi-ql
https://github.com/software-engineering-amsterdam/endless-ql

So it looks to me that the QL language used in this course is not widely used, and it is probably ok for the .ql files that correspond to this language to be classified as "QL".

@rewinfrey @pchaigno Thoughts?

@rewinfrey
Copy link
Contributor Author

What about these files?

Confirming along with @maxbrunsfeld that those are QL files.

So it looks to me that the QL language used in this course is not widely used, and it is probably ok for the .ql files that correspond to this language to be classified as "QL".

That's how I see it, too. The fact that these two separate languages happen to also share the same name is a funny coincidence.

@pchaigno as far as I know, the only official programming language using .ql and .qll as file extensions is Semmle's QL.

@alexet
Copy link

alexet commented Mar 4, 2020

We need to change the language name here to CodeQL.

@alexet
Copy link

alexet commented Mar 4, 2020

Sorry I was confused about the naming. This should stay as QL

@rewinfrey
Copy link
Contributor Author

👋 @pchaigno when you have a moment, would you mind taking another pass over this? I think the concerns about other .ql files have been addressed, but please let me know if I've missed something. 🙇

@rewinfrey
Copy link
Contributor Author

@alexet confirming I've updated Linguist in this patch to use https://github.com/github/vscode-codeql as the definitive grammar in efe19e8

@rewinfrey rewinfrey changed the title Add QL language Add CodeQL language Mar 6, 2020
@rewinfrey
Copy link
Contributor Author

A decision was made to update the name from QL to CodeQL, I've updated this patch to reflect that.

@pchaigno friendly ping 😄 This is planned to be deployed to github.com as soon as this patch is ready.

/cc @alexet

@pchaigno
Copy link
Contributor

pchaigno commented Mar 6, 2020

It looks like for those files, the language that has been invented as an assignment for a programming class at a Dutch university.

The goal of this assignment is to build a DSL for questionnaires, called QL. QL allows you to define simple forms with conditions and computed values.

Source: the readme in https://github.com/EdwinOuwehand/ql-dsl.

I think that these other two repos in your search results are related to the same university course:
https://github.com/software-engineering-amsterdam/multi-ql
https://github.com/software-engineering-amsterdam/endless-ql

So it looks to me that the QL language used in this course is not widely used, and it is probably ok for the .ql files that correspond to this language to be classified as "QL".

@maxbrunsfeld Thanks for digging into this 🙇‍♂️

LGTM otherwise!

@pchaigno pchaigno requested a review from lildude March 6, 2020 21:25
@rewinfrey rewinfrey merged commit 69bd5e6 into master Mar 9, 2020
@rewinfrey rewinfrey deleted the add-ql-language branch March 9, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants