New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeQL language #4805
Add CodeQL language #4805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @rewinfrey!
I have only one comment below, regarding the second file extension. I was also wondering if these files are of the same language?
@pchaigno the first file in that query you provided is a |
Thanks for the answers and updated pull request!
We'll need to identify the language(s) of those files. If there are enough, we'll need to add support for those languages in Linguist. Otherwise, all those files are going to be identified as QL. What about these files? |
All of those files (at least the first 5 pages) are QL 👍 . |
It looks like for those files, the language that has been invented as an assignment for a programming class at a Dutch university.
Source: the readme in https://github.com/EdwinOuwehand/ql-dsl. I think that these other two repos in your search results are related to the same university course: So it looks to me that the @rewinfrey @pchaigno Thoughts? |
Confirming along with @maxbrunsfeld that those are
That's how I see it, too. The fact that these two separate languages happen to also share the same name is a funny coincidence. @pchaigno as far as I know, the only official programming language using |
We need to change the language name here to CodeQL. |
Sorry I was confused about the naming. This should stay as QL |
👋 @pchaigno when you have a moment, would you mind taking another pass over this? I think the concerns about other |
@alexet confirming I've updated Linguist in this patch to use https://github.com/github/vscode-codeql as the definitive grammar in efe19e8 |
@maxbrunsfeld Thanks for digging into this 🙇♂️ LGTM otherwise! |
This adds Linguist detection support for the QL language.
Checklist:
The extension of the new language is used in hundreds of repositories on GitHub.com.
I have included a real-world usage sample for all extensions added in this PR:
.ql
:.qll
:I have included a syntax highlighting grammar: QL lighthouse example
/cc @alexet