Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix incorrect or missing language colours #4980

Merged
merged 4 commits into from Sep 1, 2020
Merged

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Aug 31, 2020

Fixes: #4506 / Depends on: #4978

Status of related tasks:

  1. Abolish restrictions governing colour choices
  2. Add/fix incorrect or missing language colours (this)
  3. Ungroup major languages

Description

This pull-request fixes language colours that differ from their branding, or adds colours to data/prose-type languages which, historically, haven't needed them. These changes are described in further detail in #4506; consult that thread for detail and discussion.

Caveats

Checklist

  • I am changing fixing the colours associated with languages.
    As with Ungroup major languages #4979, there's no real "changes" here, per se — the colours are either missing, or were modified from their official colours to satisfy the hopefully-soon-to-be-nuked colour-proximity requirements.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alhadis Alhadis merged commit 98f19f1 into master Sep 1, 2020
@Alhadis Alhadis deleted the colour-correction branch September 1, 2020 10:15
sambacha pushed a commit to freight-trust/linguist that referenced this pull request Sep 4, 2020
* Abolish restrictions governing colour choices

* Add/fix incorrect or missing language colours

Resolves: github-linguist#4506

Co-authored-by: Colin Seymour <colin@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of languages pending colour correction or addition
2 participants